From: Juergen Perlinger <perlinger@ntp.org>
Date: Tue, 15 Jun 2010 12:25:18 +0000 (-0400)
Subject: [Bug 1575] use snprintf with LIB_BUFLENGTH in inttoa.c, tvtoa.c, utvtoa.c
X-Git-Tag: NTP_4_2_6P2_RC7~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c4997780478f302ef65195302944ff8e804c22b2;p=thirdparty%2Fntp.git

[Bug 1575] use snprintf with LIB_BUFLENGTH in inttoa.c, tvtoa.c, utvtoa.c

bk: 4c17712eb6n4HSK2RhquqSGyco4xDA
---

diff --git a/ChangeLog b/ChangeLog
index a58f324e2..ac7f00638 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,6 @@
+* [Bug 1575] use 'snprintf' with LIB_BUFLENGTH in inttoa.c, tvtoa.c and
+  utvtoa.c
+
 ---
 (4.2.6p2-RC6) 2010/06/12 Released by Harlan Stenn <stenn@ntp.org>
 
diff --git a/libntp/inttoa.c b/libntp/inttoa.c
index b9c585c0b..f34710e1c 100644
--- a/libntp/inttoa.c
+++ b/libntp/inttoa.c
@@ -15,7 +15,7 @@ inttoa(
 	register char *buf;
 
 	LIB_GETBUF(buf);
-	snprintf(buf, sizeof(buf), "%ld", val);
+	snprintf(buf, LIB_BUFLENGTH, "%ld", val);
 
 	return buf;
 }
diff --git a/libntp/tvtoa.c b/libntp/tvtoa.c
index 19d4a94ed..9d6c76441 100644
--- a/libntp/tvtoa.c
+++ b/libntp/tvtoa.c
@@ -34,6 +34,6 @@ tvtoa(
 
 	LIB_GETBUF(buf);
 
-	(void) sprintf(buf, "%s%lu.%06lu", (isneg?"-":""), sec, usec);
+	(void) snprintf(buf, LIB_BUFLENGTH, "%s%lu.%06lu", (isneg?"-":""), sec, usec);
 	return buf;
 }
diff --git a/libntp/utvtoa.c b/libntp/utvtoa.c
index a441c4910..9d903d6f7 100644
--- a/libntp/utvtoa.c
+++ b/libntp/utvtoa.c
@@ -20,7 +20,7 @@ utvtoa(
 
 	LIB_GETBUF(buf);
 	
-	(void) sprintf(buf, "%lu.%06lu", (u_long)tv->tv_sec,
+	(void) snprintf(buf, LIB_BUFLENGTH, "%lu.%06lu", (u_long)tv->tv_sec,
 		       (u_long)tv->tv_usec);
 	return buf;
 }