From: Wang King <king.wang@huawei.com>
Date: Sat, 20 May 2017 01:31:57 +0000 (+0800)
Subject: util: Don't leak @reply in virSystemdGetMachineNameByPID
X-Git-Tag: v3.4.0-rc1~44
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c4a4c01e6e763cff0a2e110afeb2215bd511b333;p=thirdparty%2Flibvirt.git

util: Don't leak @reply in virSystemdGetMachineNameByPID

@reply is a DBusMessage object returned by virDBusCallMethod in
get machine object call path, dereference it before calling
virDBusCallMethod again to get machine name.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c
index 83737a2c6f..5d9746f995 100644
--- a/src/util/virsystemd.c
+++ b/src/util/virsystemd.c
@@ -247,6 +247,9 @@ virSystemdGetMachineNameByPID(pid_t pid)
     if (virDBusMessageRead(reply, "o", &object) < 0)
         goto cleanup;
 
+    virDBusMessageUnref(reply);
+    reply = NULL;
+
     VIR_DEBUG("Domain with pid %lld has object path '%s'",
               (long long) pid, object);