From: Jeremy Allison <jra@samba.org>
Date: Wed, 2 Sep 2020 16:58:30 +0000 (-0700)
Subject: s3: libsmb: Cleanup - ensure we initialize all stack variables to 'safe' values when... 
X-Git-Tag: talloc-2.3.2~635
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c4c00d626cd9ebe118e6f9c16ef1b0575d29f39b;p=thirdparty%2Fsamba.git

s3: libsmb: Cleanup - ensure we initialize all stack variables to 'safe' values when calling get_kdc_list() that may not touch returns on error.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
---

diff --git a/source3/libads/kerberos.c b/source3/libads/kerberos.c
index 1db285cd29a..e20e5426ebc 100644
--- a/source3/libads/kerberos.c
+++ b/source3/libads/kerberos.c
@@ -427,7 +427,7 @@ static char *get_kdc_ip_string(char *mem_ctx,
 	int count_site = 0;
 	int count_nonsite;
 	size_t num_dcs;
-	struct sockaddr_storage *dc_addrs;
+	struct sockaddr_storage *dc_addrs = NULL;
 	struct tsocket_address **dc_addrs2 = NULL;
 	const struct tsocket_address * const *dc_addrs3 = NULL;
 	char *result = NULL;