From: Ani Sinha Date: Wed, 25 Feb 2026 03:49:31 +0000 (+0530) Subject: kvm/hyperv: add synic feature to CPU only if its not enabled X-Git-Tag: v11.0.0-rc0~43^2~35 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c4cf32fc63f1879232e4a692e5208b705cec49f0;p=thirdparty%2Fqemu.git kvm/hyperv: add synic feature to CPU only if its not enabled We need to make sure that synic CPU feature is not already enabled. If it is, trying to enable it again will result in the following assertion: Unexpected error in object_property_try_add() at ../qom/object.c:1268: qemu-system-x86_64: attempt to add duplicate property 'synic' to object (type 'host-x86_64-cpu') So enable synic only if its not enabled already. Signed-off-by: Ani Sinha Link: https://lore.kernel.org/r/20260225035000.385950-27-anisinha@redhat.com Signed-off-by: Paolo Bonzini --- diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index 9d7a9ffceb8..7cfbc7832de 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -1761,7 +1761,7 @@ static int hyperv_init_vcpu(X86CPU *cpu) return ret; } - if (!cpu->hyperv_synic_kvm_only) { + if (!cpu->hyperv_synic_kvm_only && !hyperv_is_synic_enabled()) { ret = hyperv_x86_synic_add(cpu); if (ret < 0) { error_report("failed to create HyperV SynIC: %s",