From: Nick Mathewson <nickm@torproject.org>
Date: Wed, 3 Sep 2014 14:58:11 +0000 (-0400)
Subject: Fix some 'dereference-before-null-check' warnings in test_circuitlist.c
X-Git-Tag: tor-0.2.6.1-alpha~157
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c4d0d30bf3e621d5f7a7b27a7480bcdabe6274c6;p=thirdparty%2Ftor.git

Fix some 'dereference-before-null-check' warnings in test_circuitlist.c

Found by Coverity Scan.

[CID 1234704, 1234705, 1234706]
---

diff --git a/src/test/test_circuitlist.c b/src/test/test_circuitlist.c
index 97c6b98ac3..53dcab3302 100644
--- a/src/test/test_circuitlist.c
+++ b/src/test/test_circuitlist.c
@@ -79,6 +79,10 @@ test_clist_maps(void *arg)
   memset(&cam, 0, sizeof(cam));
   memset(&cdm, 0, sizeof(cdm));
 
+  tt_assert(ch1);
+  tt_assert(ch2);
+  tt_assert(ch3);
+
   ch1->cmux = tor_malloc(1);
   ch2->cmux = tor_malloc(1);
   ch3->cmux = tor_malloc(1);
@@ -161,7 +165,7 @@ test_clist_maps(void *arg)
   if (ch2)
     tor_free(ch2->cmux);
   if (ch3)
-  tor_free(ch3->cmux);
+    tor_free(ch3->cmux);
   tor_free(ch1);
   tor_free(ch2);
   tor_free(ch3);