From: Indu Bhagat <indu.bhagat@oracle.com>
Date: Fri, 28 Nov 2025 20:31:17 +0000 (-0800)
Subject: [SFrame-V3] sframe: gas: libsframe: remove padding field from FDE
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c4d25dd8e09e5b574c1a94e4567a651b2a21b512;p=thirdparty%2Fbinutils-gdb.git

[SFrame-V3] sframe: gas: libsframe: remove padding field from FDE

Remove the unused sfde_func_padding2 member from the
sframe_func_desc_entry_v3 structure.

A later patch in this series reorganizes the members of the FDE
structure in a way explicit padding is no longer necessary to keep
natural alignment.  So remove the explicit padding now.

include/
	* sframe.h: Remove sfde_func_padding2 from
	sframe_func_desc_entry_v3.
gas/
	* gen-sframe.c (output_sframe_funcdesc): Stop writing
	sfde_func_padding2.
libsframe/
	* sframe.c (sframe_encoder_write_fde): Stop writing
	sfde_func_padding2.
	* testsuite/libsframe.decode/DATA2: Regenerate binary test data.
---

diff --git a/gas/gen-sframe.c b/gas/gen-sframe.c
index 56c0c95c940..a25d8562994 100644
--- a/gas/gen-sframe.c
+++ b/gas/gen-sframe.c
@@ -747,7 +747,6 @@ output_sframe_funcdesc (symbolS *start_of_fre_section,
   else
     out_one (func_info);
   out_one (0);
-  out_two (0);
 }
 
 static void
diff --git a/include/sframe.h b/include/sframe.h
index 50dee8ebb96..fb4d7d03fce 100644
--- a/include/sframe.h
+++ b/include/sframe.h
@@ -266,7 +266,6 @@ typedef struct sframe_func_desc_entry_v3
   /* Size of the block of repeating insns.  Used for SFrame FDEs of type
      SFRAME_FDE_TYPE_PCMASK.  */
   uint8_t sfde_func_rep_size;
-  uint16_t sfde_func_padding2;
 } ATTRIBUTE_PACKED sframe_func_desc_entry_v3;
 
 /* SFrame V3 FDE.  TBD comment.  */
diff --git a/libsframe/sframe.c b/libsframe/sframe.c
index b0da92afb6b..f4c30264334 100644
--- a/libsframe/sframe.c
+++ b/libsframe/sframe.c
@@ -2134,7 +2134,6 @@ sframe_encoder_write_fde (const sframe_header *sfhp ATTRIBUTE_UNUSED,
   fdep->sfde_func_num_fres = (uint16_t)fde->func_num_fres;
   fdep->sfde_func_info = fde->func_info;
   fdep->sfde_func_rep_size = fde->func_rep_size;
-  fdep->sfde_func_padding2 = 0;
 
   *fde_write_size = sizeof (sframe_func_desc_entry_v3);
 
diff --git a/libsframe/testsuite/libsframe.decode/DATA2 b/libsframe/testsuite/libsframe.decode/DATA2
index 7a218f86bcc..b1069c3c4d1 100644
Binary files a/libsframe/testsuite/libsframe.decode/DATA2 and b/libsframe/testsuite/libsframe.decode/DATA2 differ