From: Christian Brauner Date: Fri, 23 Feb 2018 12:26:11 +0000 (+0100) Subject: lxccontainer: do_lxcapi_start() X-Git-Tag: lxc-2.0.10~243 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c4d5d860d29dd7f1b56f284a6923bfa06da93826;p=thirdparty%2Flxc.git lxccontainer: do_lxcapi_start() thread-safety: s/exit()/_exit()/g Signed-off-by: Christian Brauner --- diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c index 511ba2f4d..44f1a91b8 100644 --- a/src/lxc/lxccontainer.c +++ b/src/lxc/lxccontainer.c @@ -870,14 +870,14 @@ static bool do_lxcapi_start(struct lxc_container *c, int useinit, char * const a pid = fork(); if (pid < 0) { SYSERROR("Failed to fork first child process"); - exit(EXIT_FAILURE); + _exit(EXIT_FAILURE); } /* second parent */ if (pid != 0) { free_init_cmd(init_cmd); lxc_free_handler(handler); - exit(EXIT_SUCCESS); + _exit(EXIT_SUCCESS); } /* second child */ @@ -886,7 +886,7 @@ static bool do_lxcapi_start(struct lxc_container *c, int useinit, char * const a ret = chdir("/"); if (ret < 0) { SYSERROR("Failed to change to \"/\" directory"); - exit(EXIT_FAILURE); + _exit(EXIT_FAILURE); } keepfds[0] = handler->conf->maincmd_fd; @@ -895,13 +895,13 @@ static bool do_lxcapi_start(struct lxc_container *c, int useinit, char * const a ret = lxc_check_inherited(conf, true, keepfds, sizeof(keepfds) / sizeof(keepfds[0])); if (ret < 0) - exit(EXIT_FAILURE); + _exit(EXIT_FAILURE); /* redirect std{in,out,err} to /dev/null */ ret = null_stdfds(); if (ret < 0) { ERROR("Failed to redirect std{in,out,err} to /dev/null"); - exit(EXIT_FAILURE); + _exit(EXIT_FAILURE); } /* become session leader */ @@ -928,7 +928,7 @@ static bool do_lxcapi_start(struct lxc_container *c, int useinit, char * const a free_init_cmd(init_cmd); lxc_free_handler(handler); if (daemonize) - exit(EXIT_FAILURE); + _exit(EXIT_FAILURE); return false; } @@ -939,7 +939,7 @@ static bool do_lxcapi_start(struct lxc_container *c, int useinit, char * const a free_init_cmd(init_cmd); lxc_free_handler(handler); if (daemonize) - exit(EXIT_FAILURE); + _exit(EXIT_FAILURE); return false; } @@ -1010,9 +1010,9 @@ on_error: free_init_cmd(init_cmd); if (daemonize && ret != 0) - exit(EXIT_FAILURE); + _exit(EXIT_FAILURE); else if (daemonize) - exit(EXIT_SUCCESS); + _exit(EXIT_SUCCESS); if (ret != 0) return false;