From: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: Mon, 17 Apr 2023 11:54:00 +0000 (+0400)
Subject: rpc/ssh: ssh_userauth_agent() is not supported on win32
X-Git-Tag: v9.3.0-rc1~74
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c4ec51edd6f03e34b9c7d6c05a3e374a5cdf0876;p=thirdparty%2Flibvirt.git

rpc/ssh: ssh_userauth_agent() is not supported on win32

The function does not exist on win32.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/rpc/virnetlibsshsession.c b/src/rpc/virnetlibsshsession.c
index e71a79d0fb..8cb57e857f 100644
--- a/src/rpc/virnetlibsshsession.c
+++ b/src/rpc/virnetlibsshsession.c
@@ -700,7 +700,9 @@ virNetLibsshAuthenticate(virNetLibsshSession *sess)
             break;
         case VIR_NET_LIBSSH_AUTH_AGENT:
             /* try to authenticate using ssh-agent */
+#ifndef WIN32
             ret = ssh_userauth_agent(sess->session, NULL);
+#endif
             if (ret == SSH_AUTH_ERROR) {
                 errmsg = ssh_get_error(sess->session);
                 virReportError(VIR_ERR_LIBSSH,
@@ -861,8 +863,13 @@ virNetLibsshSessionAuthAddPasswordAuth(virNetLibsshSession *sess,
 }
 
 int
-virNetLibsshSessionAuthAddAgentAuth(virNetLibsshSession *sess)
+virNetLibsshSessionAuthAddAgentAuth(virNetLibsshSession *sess G_GNUC_UNUSED)
 {
+#ifdef WIN32
+    virReportError(VIR_ERR_LIBSSH, "%s",
+                   _("Agent authentication is not supported on this host"));
+    return -1;
+#else
     virNetLibsshAuthMethod *auth;
 
     virObjectLock(sess);
@@ -873,6 +880,7 @@ virNetLibsshSessionAuthAddAgentAuth(virNetLibsshSession *sess)
 
     virObjectUnlock(sess);
     return 0;
+#endif
 }
 
 int