From: Russell Bryant <russell@russellbryant.com>
Date: Thu, 30 Sep 2010 15:34:29 +0000 (+0000)
Subject: Fix a crash in app_sms.
X-Git-Tag: 1.4.38-rc1~49
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c4f3f68e436f7e04378adce3f09f163d549937e4;p=thirdparty%2Fasterisk.git

Fix a crash in app_sms.

Since the data being passed to the generator callback is on the stack of the
SMS() application, we must ensure that the generator is stopped before the
application exits.

ABE-2587


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@289424 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/apps/app_sms.c b/apps/app_sms.c
index b1bc849881..412ddb0d64 100644
--- a/apps/app_sms.c
+++ b/apps/app_sms.c
@@ -1506,6 +1506,12 @@ static int sms_exec (struct ast_channel *chan, void *data)
 
 	sms_log (&h, '?');			  /* log incomplete message */
 
+	/* 
+	 * The SMS generator data is on the stack.  We _MUST_ make sure the generator
+	 * is stopped before returning from this function.
+	 */
+	ast_deactivate_generator(chan);
+
 	ast_module_user_remove(u);
 	return (h.err);
 }