From: Remi Gacogne Date: Tue, 29 Jul 2025 09:42:24 +0000 (+0200) Subject: dnsdist: Increase the time granted for the "timeout then restart" test X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c4fa54896092aba67a5d078b4094c2f051fdf572;p=thirdparty%2Fpdns.git dnsdist: Increase the time granted for the "timeout then restart" test This test fails from time to time in our CI. After investigation, it turns out that sometimes the response comes just a few milliseconds after the 3 seconds timeout has expired: ``` Got answer from 127.0.0.1:14191, relayed to 127.0.0.1:36139 (UDP), took 3.00105e+06 us ``` So let's use a slightly larger timeout of 4 seconds. It will not add any delay if the response is received faster than that and will hopefully reduce the number of spurious failures. Signed-off-by: Remi Gacogne --- diff --git a/regression-tests.dnsdist/test_TimeoutResponse.py b/regression-tests.dnsdist/test_TimeoutResponse.py index e75b09970..7180c9067 100644 --- a/regression-tests.dnsdist/test_TimeoutResponse.py +++ b/regression-tests.dnsdist/test_TimeoutResponse.py @@ -102,7 +102,7 @@ class TestTimeoutBackendUdpTcp(DNSDistTest): for method in ("sendUDPQuery", "sendTCPQuery", "sendDOQQueryWrapper", "sendDOH3QueryWrapper", "sendDOTQueryWrapper", "sendDOHWithNGHTTP2QueryWrapper"): sender = getattr(self, method) - (_, receivedResponse) = sender(query, response=None, useQueue=False, timeout=3) + (_, receivedResponse) = sender(query, response=None, useQueue=False, timeout=4) self.assertTrue(receivedResponse) self.assertEqual(receivedResponse, expectedResponse)