From: Volker Lendecke <vl@samba.org>
Date: Sat, 28 Dec 2024 10:59:52 +0000 (+0100)
Subject: torture4: Use generate_random_str_list_buf()
X-Git-Tag: tdb-1.4.13~117
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c50645944eafa2a8a9a5f9c732fc6284a1f22be6;p=thirdparty%2Fsamba.git

torture4: Use generate_random_str_list_buf()

Avoid a theoretical printf("%s", NULL)

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source4/torture/raw/search.c b/source4/torture/raw/search.c
index ec4bee71baa..edca38d6766 100644
--- a/source4/torture/raw/search.c
+++ b/source4/torture/raw/search.c
@@ -1111,7 +1111,13 @@ static bool test_sorted(struct torture_context *tctx, struct smbcli_state *cli)
 	printf("Creating %d files\n", num_files);
 
 	for (i=0;i<num_files;i++) {
-		fname = talloc_asprintf(cli, BASEDIR "\\%s.txt", generate_random_str_list(tctx, 10, "abcdefgh"));
+		char randstr[11];
+		fname = talloc_asprintf(
+			cli,
+			BASEDIR "\\%s.txt",
+			generate_random_str_list_buf(randstr,
+						     sizeof(randstr),
+						     "abcdefgh"));
 		fnum = smbcli_open(cli->tree, fname, O_CREAT|O_RDWR, DENY_NONE);
 		if (fnum == -1) {
 			printf("Failed to create %s - %s\n", fname, smbcli_errstr(cli->tree));