From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Wed, 9 Jul 2008 21:14:17 +0000 (+0200)
Subject: Refactored actions for clientdb, comm_select, dns and idns to
X-Git-Tag: SQUID_3_1_0_1~49^2~143^2~28
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c5108ed58b2f0f7bef4cd1599caf5e341a57ba09;p=thirdparty%2Fsquid.git

Refactored actions for clientdb, comm_select, dns and idns to
Cache Manager singleton API.
---

diff --git a/src/client_db.cc b/src/client_db.cc
index 39df170a53..5d0cf8a75f 100644
--- a/src/client_db.cc
+++ b/src/client_db.cc
@@ -85,12 +85,10 @@ clientdbInit(void)
 }
 
 void
-clientdbRegisterWithCacheManager(CacheManager & manager)
+clientdbRegisterWithCacheManager(void)
 {
-    manager.registerAction("client_list",
-                           "Cache Client List",
-                           clientdbDump,
-                           0, 1);
+    CacheManager::GetInstance()->
+        registerAction("client_list", "Cache Client List", clientdbDump, 0, 1);
 }
 
 void
diff --git a/src/comm_select.cc b/src/comm_select.cc
index 9d778197de..3b35befb00 100644
--- a/src/comm_select.cc
+++ b/src/comm_select.cc
@@ -665,11 +665,12 @@ comm_select_init(void)
 }
 
 void
-commSelectRegisterWithCacheManager(CacheManager & manager)
+commSelectRegisterWithCacheManager(void)
 {
-    manager.registerAction("comm_select_incoming",
-                           "comm_incoming() stats",
-                           commIncomingStats, 0, 1);
+    CacheManager::GetInstance()->
+        registerAction("comm_select_incoming",
+                       "comm_incoming() stats",
+                       commIncomingStats, 0, 1);
 }
 
 /*
diff --git a/src/comm_select.h b/src/comm_select.h
index ac9d37dfe5..9f95ef5708 100644
--- a/src/comm_select.h
+++ b/src/comm_select.h
@@ -38,6 +38,6 @@
 
 class CacheManager;
 
-extern void commSelectRegisterWithCacheManager(CacheManager & manager);
+extern void commSelectRegisterWithCacheManager(void);
 
 #endif /* SQUID_COMM_SELECT_H */
diff --git a/src/comm_select_win32.cc b/src/comm_select_win32.cc
index a09ea5e160..53daf3919c 100644
--- a/src/comm_select_win32.cc
+++ b/src/comm_select_win32.cc
@@ -687,9 +687,10 @@ comm_select_init(void)
 }
 
 void
-commSelectRegisterWithCacheManager(CacheManager & manager)
+commSelectRegisterWithCacheManager(void)
 {
-    manager.registerAction("comm_select_incoming",
+    CacheManager::GetInstance()->
+            registerAction("comm_select_incoming",
                            "comm_incoming() stats",
                            commIncomingStats, 0, 1);
 }
diff --git a/src/dns.cc b/src/dns.cc
index 0df6d429d1..004ede5fb9 100644
--- a/src/dns.cc
+++ b/src/dns.cc
@@ -86,11 +86,10 @@ dnsInit(void)
 }
 
 void
-dnsRegisterWithCacheManager(CacheManager & manager)
+dnsRegisterWithCacheManager(void)
 {
-    manager.registerAction("dns",
-                           "Dnsserver Statistics",
-                           dnsStats, 0, 1);
+    CacheManager::GetInstance->
+        registerAction("dns", "Dnsserver Statistics", dnsStats, 0, 1);
 }
 
 void
diff --git a/src/dns_internal.cc b/src/dns_internal.cc
index 7a8f2ea7ab..f5f52aed79 100755
--- a/src/dns_internal.cc
+++ b/src/dns_internal.cc
@@ -1384,9 +1384,10 @@ idnsInit(void)
 }
 
 void
-idnsRegisterWithCacheManager(CacheManager & manager)
+idnsRegisterWithCacheManager(void)
 {
-    manager.registerAction("idns", "Internal DNS Statistics", idnsStats, 0, 1);
+    CacheManager::GetInstance()->
+        registerAction("idns", "Internal DNS Statistics", idnsStats, 0, 1);
 }
 
 void
diff --git a/src/main.cc b/src/main.cc
index d8aeaa5a43..10db943abf 100644
--- a/src/main.cc
+++ b/src/main.cc
@@ -993,10 +993,10 @@ mainInitialize(void)
 #endif
 #if defined(USE_SELECT) || defined(USE_SELECT_WIN32)
 
-        commSelectRegisterWithCacheManager(*manager);
+        commSelectRegisterWithCacheManager();
 #endif
 
-        clientdbRegisterWithCacheManager(*manager);
+        clientdbRegisterWithCacheManager();
 #if DELAY_POOLS
 
         DelayPools::RegisterWithCacheManager(*manager);
@@ -1005,7 +1005,7 @@ mainInitialize(void)
         DiskIOModule::RegisterAllModulesWithCacheManager();
 #if USE_DNSSERVERS
 
-        dnsRegisterWithCacheManager(*manager);
+        dnsRegisterWithCacheManager();
 #endif
 
         eventInit(*manager);
@@ -1015,7 +1015,7 @@ mainInitialize(void)
         httpHeaderRegisterWithCacheManager(*manager);
 #if !USE_DNSSERVERS
 
-        idnsRegisterWithCacheManager(*manager);
+        idnsRegisterWithCacheManager();
 #endif
 
         ipcacheRegisterWithCacheManager(*manager);
diff --git a/src/protos.h b/src/protos.h
index ceba7c908b..a88d9c414b 100644
--- a/src/protos.h
+++ b/src/protos.h
@@ -83,7 +83,7 @@ SQUIDCEXTERN void parse_IPAddress_list_token(IPAddress_list **, char *);
 /* client_side.c - FD related client side routines */
 
 SQUIDCEXTERN void clientdbInit(void);
-extern void clientdbRegisterWithCacheManager(CacheManager & manager);
+extern void clientdbRegisterWithCacheManager(void);
 
 SQUIDCEXTERN void clientdbUpdate(const IPAddress &, log_type, protocol_t, size_t);
 
@@ -135,13 +135,13 @@ SQUIDCEXTERN void disk_init(void);
 
 SQUIDCEXTERN void dnsShutdown(void);
 SQUIDCEXTERN void dnsInit(void);
-extern void dnsRegisterWithCacheManager(CacheManager & manager);
+extern void dnsRegisterWithCacheManager(void);
 SQUIDCEXTERN void dnsSubmit(const char *lookup, HLPCB * callback, void *data);
 
 /* dns_internal.c */
 SQUIDCEXTERN void idnsInit(void);
 SQUIDCEXTERN void idnsShutdown(void);
-extern void idnsRegisterWithCacheManager(CacheManager & manager);
+extern void idnsRegisterWithCacheManager(void);
 SQUIDCEXTERN void idnsALookup(const char *, IDNSCB *, void *);
 
 SQUIDCEXTERN void idnsPTRLookup(const IPAddress &, IDNSCB *, void *);