From: Mark Wielaard Date: Fri, 11 Jan 2019 19:00:17 +0000 (+0100) Subject: Bug 402480 Do not use %esp in clobber list. X-Git-Tag: VALGRIND_3_15_0~100 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c512949082c4fc2285a82e102d4212c66e034a31;p=thirdparty%2Fvalgrind.git Bug 402480 Do not use %esp in clobber list. This is the same fix as for amd64-linux, but now for x86-linux. --- diff --git a/none/tests/x86-linux/bug345887.c b/none/tests/x86-linux/bug345887.c index f2e8a8ddec..ef21d4e324 100644 --- a/none/tests/x86-linux/bug345887.c +++ b/none/tests/x86-linux/bug345887.c @@ -12,12 +12,14 @@ static void inner(void) "movl $0x105, %%esi\n" "movl $0x106, %%edi\n" // not %ebp as mdb is then not able to reconstruct stack trace + // clobbering %esp is really bad, but that is kind of the point + // we don't add it to the clobber list since gcc9 warns about that "movl $0x108, %%esp\n" "movl $0x1234, (%%eax)\n" // should cause SEGV here "ud2" // should never get here : // no output registers : // no input registers - : "memory", "%eax", "%ebx", "%ecx", "%edx", "%esi", "%edi", "%esp"); + : "memory", "%eax", "%ebx", "%ecx", "%edx", "%esi", "%edi"); } __attribute__((noinline))