From: Stefan Metzmacher <metze@samba.org>
Date: Thu, 12 Jan 2023 09:49:13 +0000 (+0100)
Subject: s3:rpc_server: make use of tstream_bsd_fail_readv_first_error(true)
X-Git-Tag: talloc-2.4.2~1178
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c5201cd0b59647c41ac46ed1f4efb1a72bc37bf9;p=thirdparty%2Fsamba.git

s3:rpc_server: make use of tstream_bsd_fail_readv_first_error(true)

This avoids doing useless work in case the client connection
is already broken.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source3/rpc_server/rpc_host.c b/source3/rpc_server/rpc_host.c
index 92222dd17d4..ab9ad33c562 100644
--- a/source3/rpc_server/rpc_host.c
+++ b/source3/rpc_server/rpc_host.c
@@ -967,6 +967,8 @@ static struct tevent_req *rpc_host_bind_read_send(
 		close(sock_dup);
 		return tevent_req_post(req, ev);
 	}
+	/* as server we want to fail early */
+	tstream_bsd_fail_readv_first_error(state->plain, true);
 
 	if (transport == NCACN_NP) {
 		subreq = tstream_npa_accept_existing_send(
diff --git a/source3/rpc_server/rpc_worker.c b/source3/rpc_server/rpc_worker.c
index e923110940d..8ed7444e003 100644
--- a/source3/rpc_server/rpc_worker.c
+++ b/source3/rpc_server/rpc_worker.c
@@ -390,6 +390,8 @@ static void rpc_worker_new_client(
 				  strerror(errno));
 			goto fail;
 		}
+		/* as server we want to fail early */
+		tstream_bsd_fail_readv_first_error(tstream, true);
 	}
 	sock = -1;