From: Mark Brown <broonie@kernel.org>
Date: Mon, 15 Dec 2025 01:10:13 +0000 (+0900)
Subject: ASoC: qcom: Fix confusing cleanup.h
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c5224b8a1ba52d70b3fc2548109bd04bbbc0c8a6;p=thirdparty%2Fkernel%2Flinux.git

ASoC: qcom: Fix confusing cleanup.h

Merge series from Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>:

Please, please stop ending cleanup.h patches for very simple code like:

  foo = kzalloc();
  kfree(foo);
  return;

... *if you do not intend to read cleanup.h*. These changes are making
simple code not necessarily simpler. But worse, if you do not read
cleanup.h then you introduce actually undesired, error-prone and wrong
style of having constructors with redundant values (= NULL).

This is actually worse code.

If you do not agree in declaration-in-place-of-use (fair!), then do not
use cleanup.h. If you want to use cleanup.h, then please read cleanup.h
before.

This is second mixup I see recently around Qualcomm files.
---

c5224b8a1ba52d70b3fc2548109bd04bbbc0c8a6