From: Oliver Kurth <okurth@vmware.com>
Date: Wed, 4 Mar 2020 20:07:11 +0000 (-0800)
Subject: Rectify a log spew in vmsvc logging (vmware-vmsvc-root.log)
X-Git-Tag: stable-11.1.0~66
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c53e54623f537e96a66811e16d48a2523f4833f8;p=thirdparty%2Fopen-vm-tools.git

Rectify a log spew in vmsvc logging (vmware-vmsvc-root.log)

When a LSI Logic Parallel SCSI controller sits in PCI bus 0
(SCSI controller 0), the Linux disk device enumeration does not provide
a "label" file with the controller name.  This results in messages like

'GuestInfoGetDiskDevice: Missing disk device name; VMDK mapping
unavailable for "/var/log", fsName: "/dev/sda2"'

repeatedly appearing in the vmsvc logging.  The patch converts what
previously was a warning message to a debug message and thus avoids
the log spew.

This patch has been made available for open-vm-tools 11.0.x on the
open-vm-tools github repo.

https://github.com/vmware/open-vm-tools/issues/404
---

diff --git a/open-vm-tools/services/plugins/guestInfo/diskInfo.c b/open-vm-tools/services/plugins/guestInfo/diskInfo.c
index 878276ce7..032c09285 100644
--- a/open-vm-tools/services/plugins/guestInfo/diskInfo.c
+++ b/open-vm-tools/services/plugins/guestInfo/diskInfo.c
@@ -846,9 +846,9 @@ GuestInfoGetDiskDevice(const char *fsName,
     */
    for (indx = 0; indx < partEntry->diskDevCnt; indx++) {
       if (partEntry->diskDevNames[indx][0] == '\0') {
-         g_warning("%s: Missing disk device name; VMDK mapping unavailable "
-                   "for \"%s\", fsName: \"%s\"\n", __FUNCTION__,
-                   partEntry->name, fsName);
+         g_debug("%s: Missing disk device name; VMDK mapping unavailable "
+                 "for \"%s\", fsName: \"%s\"\n", __FUNCTION__,
+                 partEntry->name, fsName);
          partEntry->diskDevCnt = 0;
          free(partEntry->diskDevNames);
          partEntry->diskDevNames = NULL;