From: Ondřej Surý <ondrej@isc.org>
Date: Mon, 5 Aug 2024 08:24:37 +0000 (+0200)
Subject: Fix assertion failure when checking named-checkconf version
X-Git-Tag: alessio/regression/a26055f03e~7^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c54880e3fad9f6c569de04fccf5489372b624311;p=thirdparty%2Fbind9.git

Fix assertion failure when checking named-checkconf version

The dst_lib_destroy() should be called only if dst_lib_init() was called
before.  In named-checkconf, that is guarded by dst_cleanup variable
that was erroneously set to true by default.  Set the dst_cleanup to
'false' by default.
---

diff --git a/bin/check/named-checkconf.c b/bin/check/named-checkconf.c
index f4ed602c496..d8ee57074f9 100644
--- a/bin/check/named-checkconf.c
+++ b/bin/check/named-checkconf.c
@@ -593,7 +593,7 @@ main(int argc, char **argv) {
 	const char *conffile = NULL;
 	isc_mem_t *mctx = NULL;
 	isc_result_t result = ISC_R_SUCCESS;
-	bool cleanup_dst = true;
+	bool cleanup_dst = false;
 	bool load_zones = false;
 	bool list_zones = false;
 	bool print = false;