From: Ralph Boehme Date: Fri, 2 Mar 2018 14:50:29 +0000 (+0100) Subject: s3: smbd/durable: remove dev and inode check from vfs_default_durable_reconnect_check... X-Git-Tag: ldb-1.3.6~67 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c5680ba4b27b35d403cceb6f34cd383352292428;p=thirdparty%2Fsamba.git s3: smbd/durable: remove dev and inode check from vfs_default_durable_reconnect_check_stat() On a cluster filesystem the device numbers may differ on the cluster nodes. We already verify the file_id in vfs_default_durable_reconnect(), so we can safely remove the dev/inode checks. Bug: https://bugzilla.samba.org/show_bug.cgi?id=13318 Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison (cherry picked from commit 0a91ade5272698c094137fa28d2ad4723b5963cf) Autobuild-User(v4-8-test): Karolin Seeger Autobuild-Date(v4-8-test): Thu Jul 12 17:42:50 CEST 2018 on sn-devel-144 --- diff --git a/source3/smbd/durable.c b/source3/smbd/durable.c index 602a96e1fe5..2a5ddc00268 100644 --- a/source3/smbd/durable.c +++ b/source3/smbd/durable.c @@ -305,30 +305,6 @@ static bool vfs_default_durable_reconnect_check_stat( { int ret; - if (cookie_st->st_ex_dev != fsp_st->st_ex_dev) { - DEBUG(1, ("vfs_default_durable_reconnect (%s): " - "stat_ex.%s differs: " - "cookie:%llu != stat:%llu, " - "denying durable reconnect\n", - name, - "st_ex_dev", - (unsigned long long)cookie_st->st_ex_dev, - (unsigned long long)fsp_st->st_ex_dev)); - return false; - } - - if (cookie_st->st_ex_ino != fsp_st->st_ex_ino) { - DEBUG(1, ("vfs_default_durable_reconnect (%s): " - "stat_ex.%s differs: " - "cookie:%llu != stat:%llu, " - "denying durable reconnect\n", - name, - "st_ex_ino", - (unsigned long long)cookie_st->st_ex_ino, - (unsigned long long)fsp_st->st_ex_ino)); - return false; - } - if (cookie_st->st_ex_mode != fsp_st->st_ex_mode) { DEBUG(1, ("vfs_default_durable_reconnect (%s): " "stat_ex.%s differs: "