From: Andreas Schneider <asn@samba.org>
Date: Wed, 10 Jun 2020 15:35:55 +0000 (+0200)
Subject: s3:samr: Add missing NULL pointer check
X-Git-Tag: ldb-2.2.0~103
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c57276cae62f69be65cccfc92d5689ec6c9e28e4;p=thirdparty%2Fsamba.git

s3:samr: Add missing NULL pointer check

Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Isaac Boukris <iboukris@samba.org>
---

diff --git a/source3/rpc_server/samr/srv_samr_chgpasswd.c b/source3/rpc_server/samr/srv_samr_chgpasswd.c
index 8bc7af09ee9..cb9837ecf01 100644
--- a/source3/rpc_server/samr/srv_samr_chgpasswd.c
+++ b/source3/rpc_server/samr/srv_samr_chgpasswd.c
@@ -638,6 +638,9 @@ the string %%u, and the given string %s does not.\n", passwordprogram ));
 					chatsequence,
 					"%n",
 					newpass);
+	if (chatsequence == NULL) {
+		return false;
+	}
 	return chat_with_program(passwordprogram,
 				pass,
 				chatsequence,