From: Roel Kluin Date: Fri, 30 Jan 2009 01:32:20 +0000 (-0800) Subject: drivers/net/skfp: if !capable(CAP_NET_ADMIN): inverted logic X-Git-Tag: v2.6.28.6~29 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c572a7072873729d308f034e1e1017780f0c48b3;p=thirdparty%2Fkernel%2Fstable.git drivers/net/skfp: if !capable(CAP_NET_ADMIN): inverted logic [ Upstream commit c25b9abbc2c2c0da88e180c3933d6e773245815a ] Fix inverted logic Signed-off-by: Roel Kluin Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/net/skfp/skfddi.c b/drivers/net/skfp/skfddi.c index a2b092bb3626b..b7d829fed3dfa 100644 --- a/drivers/net/skfp/skfddi.c +++ b/drivers/net/skfp/skfddi.c @@ -998,9 +998,9 @@ static int skfp_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) break; case SKFP_CLR_STATS: /* Zero out the driver statistics */ if (!capable(CAP_NET_ADMIN)) { - memset(&lp->MacStat, 0, sizeof(lp->MacStat)); - } else { status = -EPERM; + } else { + memset(&lp->MacStat, 0, sizeof(lp->MacStat)); } break; default: