From: Tim Wiederhake <twiederh@redhat.com>
Date: Wed, 12 Jan 2022 11:17:39 +0000 (+0100)
Subject: virInterfaceDefDevFormat: Add missing error handling
X-Git-Tag: v8.1.0-rc1~472
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c5860d177bb54687a8f64da9cf52774e539da772;p=thirdparty%2Flibvirt.git

virInterfaceDefDevFormat: Add missing error handling

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c
index f2b3804bec..150616bda9 100644
--- a/src/conf/interface_conf.c
+++ b/src/conf/interface_conf.c
@@ -1089,13 +1089,16 @@ virInterfaceDefDevFormat(virBuffer *buf,
                 virBufferAsprintf(buf, "<mac address='%s'/>\n", def->mac);
             break;
         case VIR_INTERFACE_TYPE_BRIDGE:
-            virInterfaceBridgeDefFormat(buf, def);
+            if (virInterfaceBridgeDefFormat(buf, def) < 0)
+                return -1;
             break;
         case VIR_INTERFACE_TYPE_BOND:
-            virInterfaceBondDefFormat(buf, def);
+            if (virInterfaceBondDefFormat(buf, def) < 0)
+                return -1;
             break;
         case VIR_INTERFACE_TYPE_VLAN:
-            virInterfaceVlanDefFormat(buf, def);
+            if (virInterfaceVlanDefFormat(buf, def) < 0)
+                return -1;
             break;
     }