From: Tim Duesterhus <tim@bastelstu.be>
Date: Sat, 16 Oct 2021 15:48:15 +0000 (+0200)
Subject: CLEANUP: Apply strcmp.cocci
X-Git-Tag: v2.5-dev11~49
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c5aa113d805aa31a59e3a26f5f656b1fa0d526d0;p=thirdparty%2Fhaproxy.git

CLEANUP: Apply strcmp.cocci

This fixes the use of the various *cmp functions to use != 0 or == 0.
---

diff --git a/src/cfgparse.c b/src/cfgparse.c
index f013928f61..892170284f 100644
--- a/src/cfgparse.c
+++ b/src/cfgparse.c
@@ -1536,7 +1536,7 @@ static void check_section_position(char *section_name,
                                    const char *file, int linenum,
                                    int *non_global_parsed)
 {
-	if (!strcmp(section_name, "global")) {
+	if (strcmp(section_name, "global") == 0) {
 		if (*non_global_parsed == 1)
 		        _ha_diag_warning("parsing [%s:%d] : global section detected after a non-global one, the prevalence of their statements is unspecified\n", file, linenum);
 	}
diff --git a/src/cli.c b/src/cli.c
index a3ee4c442e..6a46f138c7 100644
--- a/src/cli.c
+++ b/src/cli.c
@@ -1714,11 +1714,11 @@ static int cli_parse_expert_experimental_mode(char **args, char *payload, struct
 	if (!cli_has_level(appctx, ACCESS_LVL_ADMIN))
 		return 1;
 
-	if (!strcmp(args[0], "expert-mode")) {
+	if (strcmp(args[0], "expert-mode") == 0) {
 		level = ACCESS_EXPERT;
 		level_str = "expert-mode";
 	}
-	else if (!strcmp(args[0], "experimental-mode")) {
+	else if (strcmp(args[0], "experimental-mode") == 0) {
 		level = ACCESS_EXPERIMENTAL;
 		level_str = "experimental-mode";
 	}
diff --git a/src/server.c b/src/server.c
index b8908cefaf..15c4d0536f 100644
--- a/src/server.c
+++ b/src/server.c
@@ -4681,7 +4681,7 @@ static int cli_parse_add_server(char **args, char *payload, struct appctx *appct
 
 		while (1) {
 			/* check for duplicate server */
-			if (!strcmp(srv->id, next->id)) {
+			if (strcmp(srv->id, next->id) == 0) {
 				ha_alert("Already exists a server with the same name in backend.\n");
 				goto out;
 			}