From: Jörg Behrmann Date: Wed, 22 Oct 2025 11:53:56 +0000 (+0200) Subject: log: make OSC escape sequences valid X-Git-Tag: v26~64^2~1 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c5b0792dbbe8d8b8fd5b5529887f5e16da33d304;p=thirdparty%2Fmkosi.git log: make OSC escape sequences valid OSC escape sequences ("ESC ]" aka "\033]") need to be terminated with a string terminator code ST ("\033\"). Commit f26cb341 introduced some OSC escape sequences that resulted in all mkosi output being hidden when using the Kitty terminal: https://github.com/kovidgoyal/kitty/issues/9139 Fixes: f26cb341 Co-Authored-By: j --- diff --git a/mkosi/log.py b/mkosi/log.py index 0ad3d0342..889c8814b 100644 --- a/mkosi/log.py +++ b/mkosi/log.py @@ -33,11 +33,14 @@ def log_step(text: str) -> None: # easily which step generated the exception. The exception # or error will only be printed after we finish cleanup. if not terminal_is_dumb(): - print(f"\033]0;mkosi: {text}", file=sys.stderr, end="") + print(f"\033]0;mkosi: {text}\033\\", file=sys.stderr, end="") + # konsole does not support ESC ]0; title ST, but instead supports this + print(f"\033]30;mkosi: {text}\033\\", file=sys.stderr, end="") logging.info(f"{prefix}({text})") else: if not terminal_is_dumb(): - print(f"\033]0;mkosi: {text}", file=sys.stderr, end="") + print(f"\033]0;mkosi: {text}\033\\", file=sys.stderr, end="") + print(f"\033]30;mkosi: {text}\033\\", file=sys.stderr, end="") logging.info(f"{prefix}{Style.bold}{text}{Style.reset}")