From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Mon, 2 Feb 2026 08:42:49 +0000 (+0200)
Subject: lib-storage: mailbox_verify_existing_name() - Minor NFC normalization error handling fix
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c5cce165fa112dcd347327b8d95fbb8f949bb689;p=thirdparty%2Fdovecot%2Fcore.git

lib-storage: mailbox_verify_existing_name() - Minor NFC normalization error handling fix

Mainly this fixes dead code complaint from static analyzer, because
practically the error handling ended up being identical anyway.

Broken by d346ca98293747c804276ba7f86245def47a8308
---

diff --git a/src/lib-storage/mail-storage.c b/src/lib-storage/mail-storage.c
index 5df5707d2b..2e67c1b8ca 100644
--- a/src/lib-storage/mail-storage.c
+++ b/src/lib-storage/mail-storage.c
@@ -1747,9 +1747,10 @@ static int mailbox_verify_existing_name_int(struct mailbox *box)
 		if (ret == 0) {
 			i_assert(box->storage->error == MAIL_ERROR_NOTFOUND);
 			ret = -1;
+		} else {
+			ret = mailbox_get_path_to(box,
+				MAILBOX_LIST_PATH_TYPE_MAILBOX, &path);
 		}
-		ret = mailbox_get_path_to(box, MAILBOX_LIST_PATH_TYPE_MAILBOX,
-					  &path);
 	}
 
 	if (ret < 0) {