From: Stefan Metzmacher <metze@samba.org>
Date: Fri, 14 Feb 2025 22:22:45 +0000 (+0100)
Subject: libcli/auth: let NTLMv2_RESPONSE_verify_netlogon_creds() check RODC callers check... 
X-Git-Tag: tevent-0.17.0~673
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c5d2659688f3c017cf4d63eb2217a2098cffd6a3;p=thirdparty%2Fsamba.git

libcli/auth: let NTLMv2_RESPONSE_verify_netlogon_creds() check RODC callers check computer_name

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/libcli/auth/smbencrypt.c b/libcli/auth/smbencrypt.c
index ed9c52e0ede..03195855e92 100644
--- a/libcli/auth/smbencrypt.c
+++ b/libcli/auth/smbencrypt.c
@@ -1341,10 +1341,18 @@ NTSTATUS NTLMv2_RESPONSE_verify_netlogon_creds(const char *account_name,
 
 	case SEC_CHAN_RODC:
 		/*
-		 * TODO:
 		 * MS-NRPC 3.5.4.5.1.2 RODC server cachability validation
+		 *
+		 * The caller must check based on
+		 * the computer name!
 		 */
-		break;
+		if (_computer_name == NULL) {
+			TALLOC_FREE(frame);
+			return NT_STATUS_INTERNAL_ERROR;
+		}
+
+		TALLOC_FREE(frame);
+		return NT_STATUS_OK;
 	}
 
 	TALLOC_FREE(frame);