From: lpsolit%gmail.com <>
Date: Fri, 22 May 2009 08:31:30 +0000 (+0000)
Subject: Back out bug 441496: it breaks Safari and Google Chrome
X-Git-Tag: bugzilla-3.4rc1~30
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c5dd9f3b9fe8cbfe705c9956b581f4f25ea040ff;p=thirdparty%2Fbugzilla.git

Back out bug 441496: it breaks Safari and Google Chrome
---

diff --git a/buglist.cgi b/buglist.cgi
index c4f3eabf30..ac7037854c 100755
--- a/buglist.cgi
+++ b/buglist.cgi
@@ -149,20 +149,17 @@ my $format = $template->get_format("list/list", scalar $cgi->param('format'),
 # to the URL.
 #
 # Server push is a Netscape 3+ hack incompatible with MSIE, Lynx, and others. 
-# Safari 2.0.2 (Webkit 416.11) and above support it.
+# Even Communicator 4.51 has bugs with it, especially during page reload.
+# http://www.browsercaps.org used as source of compatible browsers.
+# Safari (WebKit) does not support it, despite a UA that says otherwise (bug 188712)
 # MSIE 5+ supports it on Mac (but not on Windows) (bug 190370)
 #
-my $webkitversion = "";
-if ($ENV{'HTTP_USER_AGENT'} =~ /WebKit\/(\d+)/) {
-  $webkitversion = $1;
-}
-
 my $serverpush =
   $format->{'extension'} eq "html"
     && exists $ENV{'HTTP_USER_AGENT'} 
       && $ENV{'HTTP_USER_AGENT'} =~ /Mozilla.[3-9]/ 
         && (($ENV{'HTTP_USER_AGENT'} !~ /[Cc]ompatible/) || ($ENV{'HTTP_USER_AGENT'} =~ /MSIE 5.*Mac_PowerPC/))
-          && (!$webkitversion || $webkitversion >= 416)
+          && $ENV{'HTTP_USER_AGENT'} !~ /WebKit/
             && !$agent
               && !defined($cgi->param('serverpush'))
                 || $cgi->param('serverpush');