From: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: Mon, 27 Jan 2025 13:32:19 +0000 (+0100)
Subject: migration/dirtyrate: Do not unlock cpu_list lock twice
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c60c1077a7eeadcf35a4905572e89403a2bc4c6a;p=thirdparty%2Fqemu.git

migration/dirtyrate: Do not unlock cpu_list lock twice

&qemu_cpu_list_lock is locked within the WITH_QEMU_LOCK_GUARD()
context, then unlocked. No need to manually unlock it.

Fixes: 370ed600296 ("cpu: expose qemu_cpu_list_lock for lock-guard use")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-ID: <20250128135429.8500-2-philmd@linaro.org>
---

diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
index 986624c79a..58f0467062 100644
--- a/migration/dirtyrate.c
+++ b/migration/dirtyrate.c
@@ -174,7 +174,6 @@ retry:
         if (gen_id != cpu_list_generation_id_get()) {
             g_free(records);
             g_free(stat->rates);
-            cpu_list_unlock();
             goto retry;
         }
         vcpu_dirty_stat_collect(records, false);