From: Lennart Poettering <lennart@poettering.net>
Date: Mon, 22 Jul 2019 08:24:50 +0000 (+0200)
Subject: random-seed: drop falling back to O_WRONLY if O_RDWR on /dev/urandom doesn't work
X-Git-Tag: v243-rc1~32^2~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c6127c39965aa7f13ee8b311e3f89f6f3c54a730;p=thirdparty%2Fsystemd.git

random-seed: drop falling back to O_WRONLY if O_RDWR on /dev/urandom doesn't work

There's no reason why writing should work if reading and writing
doesn't. Let's simplify this hence. /dev/urandom is generally an r/w
device, and everything else would be a serious system misconfiguration.
---

diff --git a/src/random-seed/random-seed.c b/src/random-seed/random-seed.c
index 1a1ce8caa4a..dc148ebc86a 100644
--- a/src/random-seed/random-seed.c
+++ b/src/random-seed/random-seed.c
@@ -67,13 +67,8 @@ static int run(int argc, char *argv[]) {
                         write_seed_file = true;
 
                 random_fd = open("/dev/urandom", O_RDWR|O_CLOEXEC|O_NOCTTY, 0600);
-                if (random_fd < 0) {
-                        write_seed_file = false;
-
-                        random_fd = open("/dev/urandom", O_WRONLY|O_CLOEXEC|O_NOCTTY, 0600);
-                        if (random_fd < 0)
-                                return log_error_errno(errno, "Failed to open /dev/urandom: %m");
-                }
+                if (random_fd < 0)
+                        return log_error_errno(errno, "Failed to open /dev/urandom: %m");
 
                 read_seed_file = true;