From: Nikolay Aleksandrov Date: Thu, 11 Apr 2019 12:08:25 +0000 (+0300) Subject: net: bridge: multicast: use rcu to access port list from br_multicast_start_querier X-Git-Tag: v3.18.139~16 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c63dcecbc234de4e80d1f788cd3c8ef60024f75b;p=thirdparty%2Fkernel%2Fstable.git net: bridge: multicast: use rcu to access port list from br_multicast_start_querier [ Upstream commit c5b493ce192bd7a4e7bd073b5685aad121eeef82 ] br_multicast_start_querier() walks over the port list but it can be called from a timer with only multicast_lock held which doesn't protect the port list, so use RCU to walk over it. Fixes: c83b8fab06fc ("bridge: Restart queries when last querier expires") Signed-off-by: Nikolay Aleksandrov Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c index c08f510fce309..75bfe05ca4739 100644 --- a/net/bridge/br_multicast.c +++ b/net/bridge/br_multicast.c @@ -2023,7 +2023,8 @@ static void br_multicast_start_querier(struct net_bridge *br, __br_multicast_open(br, query); - list_for_each_entry(port, &br->port_list, list) { + rcu_read_lock(); + list_for_each_entry_rcu(port, &br->port_list, list) { if (port->state == BR_STATE_DISABLED || port->state == BR_STATE_BLOCKING) continue; @@ -2035,6 +2036,7 @@ static void br_multicast_start_querier(struct net_bridge *br, br_multicast_enable(&port->ip6_own_query); #endif } + rcu_read_unlock(); } int br_multicast_toggle(struct net_bridge *br, unsigned long val)