From: Jeff Lucovsky Date: Mon, 24 Apr 2023 13:51:56 +0000 (-0400) Subject: reputation: Release memory on key add fails X-Git-Tag: suricata-7.0.1~73 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c666317038d9ced0df39cb5d783d87e687c3248a;p=thirdparty%2Fsuricata.git reputation: Release memory on key add fails Ensure that memory for the reputation key is released on failed adds. Contributed by Giuseppe Longo Issue: 5748 --- diff --git a/src/reputation.c b/src/reputation.c index 57beefbe58..23080620c1 100644 --- a/src/reputation.c +++ b/src/reputation.c @@ -100,6 +100,7 @@ static void SRepCIDRAddNetblock(SRepCIDRTree *cidr_ctx, char *ip, int cat, uint8 SCLogDebug("adding ipv6 host %s", ip); if (SCRadixAddKeyIPV6String(ip, cidr_ctx->srepIPV6_tree[cat], (void *)user_data) == NULL) { + SCFree(user_data); SCLogWarning("failed to add ipv6 host %s", ip); } @@ -115,6 +116,7 @@ static void SRepCIDRAddNetblock(SRepCIDRTree *cidr_ctx, char *ip, int cat, uint8 SCLogDebug("adding ipv4 host %s", ip); if (SCRadixAddKeyIPV4String(ip, cidr_ctx->srepIPV4_tree[cat], (void *)user_data) == NULL) { + SCFree(user_data); SCLogWarning("failed to add ipv4 host %s", ip); } }