From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Fri, 14 Feb 2025 11:41:26 +0000 (+0200)
Subject: auth: Split off auth_request_want_failure_delay()
X-Git-Tag: 2.4.1~189
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c66808d49103ef7d06d34ffa4243f5893526c529;p=thirdparty%2Fdovecot%2Fcore.git

auth: Split off auth_request_want_failure_delay()
---

diff --git a/src/auth/auth-request-handler.c b/src/auth/auth-request-handler.c
index f71dcef6c9..01e768702c 100644
--- a/src/auth/auth-request-handler.c
+++ b/src/auth/auth-request-handler.c
@@ -212,6 +212,19 @@ auth_str_append_extra_fields(struct auth_request *request, string_t *dest)
 	}
 }
 
+static bool auth_request_want_failure_delay(struct auth_request *request)
+{
+	if (request->failure_nodelay) {
+		/* passdb specifically requested not to delay the reply. */
+		return FALSE;
+	}
+	if (shutting_down) {
+		/* process is shutting down - finish failures immediately. */
+		return FALSE;
+	}
+	return TRUE;
+}
+
 static void
 auth_request_handle_failure(struct auth_request *request, const char *reply)
 {
@@ -235,8 +248,7 @@ auth_request_handle_failure(struct auth_request *request, const char *reply)
 
 	e_debug(request->event, "handling failure, nodelay=%d",
 		(int) request->failure_nodelay);
-	if (request->failure_nodelay || shutting_down) {
-		/* passdb specifically requested not to delay the reply. */
+	if (!auth_request_want_failure_delay(request)) {
 		handler->callback(reply, handler->conn);
 		auth_request_unref(&request);
 		return;