From: Herb Lewis <herb@samba.org>
Date: Sat, 13 Dec 2008 19:31:20 +0000 (-0800)
Subject: don't return 0 on error - bad for scripts
X-Git-Tag: samba-4.0.0alpha6~479^2~3^2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c689d75c27c9fb0a0b3ae05fc75d38671055cd8e;p=thirdparty%2Fsamba.git

don't return 0 on error - bad for scripts
---

diff --git a/source3/utils/smbcacls.c b/source3/utils/smbcacls.c
index 1bfc4757da3..f7f12722158 100644
--- a/source3/utils/smbcacls.c
+++ b/source3/utils/smbcacls.c
@@ -735,6 +735,8 @@ static int owner_set(struct cli_state *cli, enum chown_mode change_mode,
 
 	if (!cli_set_secdesc(cli, fnum, sd)) {
 		printf("ERROR: secdesc set failed: %s\n", cli_errstr(cli));
+		cli_close(cli, fnum);
+		return EXIT_FAILED;
 	}
 
 	cli_close(cli, fnum);