From: Parav Pandit Date: Thu, 6 Jun 2024 04:38:08 +0000 (+0300) Subject: devlink: Fix setting max_io_eqs as the sole attribute X-Git-Tag: v6.10.0~4 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c6c39f3c6da4bf093aad6d0eb1c5b07a7aa2dab7;p=thirdparty%2Fiproute2.git devlink: Fix setting max_io_eqs as the sole attribute dl_opts_put() function missed to consider IO eqs option flag. Due to this, when max_io_eqs setting is applied only when it is combined with other attributes such as roce/hw_addr. When max_io_eqs is the only attribute set, it missed to apply the attribute. Fix it by adding the missing flag. Fixes: e8add23c59b7 ("devlink: Support setting max_io_eqs") Signed-off-by: Parav Pandit Signed-off-by: Stephen Hemminger --- diff --git a/devlink/devlink.c b/devlink/devlink.c index 4929ab08..57bcc965 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -2637,7 +2637,7 @@ static void dl_opts_put(struct nlmsghdr *nlh, struct dl *dl) mnl_attr_put_u64(nlh, DEVLINK_ATTR_TRAP_POLICER_BURST, opts->trap_policer_burst); if (opts->present & (DL_OPT_PORT_FUNCTION_HW_ADDR | DL_OPT_PORT_FUNCTION_STATE | - DL_OPT_PORT_FN_CAPS)) + DL_OPT_PORT_FN_CAPS | DL_OPT_PORT_FN_MAX_IO_EQS)) dl_function_attr_put(nlh, opts); if (opts->present & DL_OPT_PORT_FLAVOUR) mnl_attr_put_u16(nlh, DEVLINK_ATTR_PORT_FLAVOUR, opts->port_flavour);