From: Alan Modra <amodra@gmail.com>
Date: Wed, 14 May 2025 08:07:42 +0000 (+0930)
Subject: resbin: don't pass NULL as printf %s arg
X-Git-Tag: binutils-2_45~593
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c6c8d0b82175;p=thirdparty%2Fbinutils-gdb.git

resbin: don't pass NULL as printf %s arg

Fix three place where a NULL could be passed to "toosmall".
---

diff --git a/binutils/resbin.c b/binutils/resbin.c
index 3bce84f6766..889126e9e32 100644
--- a/binutils/resbin.c
+++ b/binutils/resbin.c
@@ -1250,7 +1250,7 @@ bin_to_res_version (windres_bfd *wrbfd, const bfd_byte *data,
 
 	      vst = res_alloc (sizeof (rc_ver_stringtable));
 
-	      if (!get_version_header (wrbfd, data, length, (const char *) NULL,
+	      if (!get_version_header (wrbfd, data, length, "version stringtable",
 				       &vst->language, &stverlen, &vallen,
 				       &type, &off))
 		return NULL;
@@ -1284,9 +1284,9 @@ bin_to_res_version (windres_bfd *wrbfd, const bfd_byte *data,
 
 		  vs = res_alloc (sizeof (rc_ver_stringinfo));
 
-		  if (!get_version_header (wrbfd, data, length,
-					   (const char *) NULL, &vs->key,
-					   &sverlen, &vallen, &type, &off))
+		  if (!get_version_header (wrbfd, data, length, "version string",
+					   &vs->key, &sverlen, &vallen,
+					   &type, &off))
 		    return NULL;
 
 		  data += off;
@@ -1348,7 +1348,7 @@ bin_to_res_version (windres_bfd *wrbfd, const bfd_byte *data,
 	  data += off;
 	  length -= off;
 
-	  if (!get_version_header (wrbfd, data, length, (const char *) NULL,
+	  if (!get_version_header (wrbfd, data, length, "version varfileinfo",
 				   &vi->u.var.key, &verlen, &vallen,
 				   &type, &off))
 	    return NULL;