From: Michael Tremer <michael.tremer@ipfire.org>
Date: Wed, 4 Oct 2023 17:12:17 +0000 (+0000)
Subject: transaction: Fix truncation of integer when showing transaction
X-Git-Tag: 0.9.30~1545
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c6dd84ac95ae45528e1e87f481e86e1b2675217b;p=pakfire.git

transaction: Fix truncation of integer when showing transaction

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/libpakfire/transaction.c b/src/libpakfire/transaction.c
index ab21c6136..19a88469f 100644
--- a/src/libpakfire/transaction.c
+++ b/src/libpakfire/transaction.c
@@ -1185,10 +1185,18 @@ PAKFIRE_EXPORT char* pakfire_transaction_dump(struct pakfire_transaction* transa
 	// How much more space do we need?
 	ssize_t sizechange = pakfire_transaction_installsizechange(transaction);
 
-	r = pakfire_transaction_add_usage_line(&s, width,
-		(sizechange >= 0) ? _("Required Space") : _("Freed Space"), abs(sizechange));
-	if (r < 0)
-		goto ERROR;
+	// Show if we need more space
+	if (sizechange > 0) {
+		r = pakfire_transaction_add_usage_line(&s, width, _("Required Space"), sizechange);
+		if (r < 0)
+			goto ERROR;
+
+	// Show if we are freeing space
+	} else if (sizechange < 0) {
+		r = pakfire_transaction_add_usage_line(&s, width, _("Freed Space"), -sizechange);
+		if (r < 0)
+			goto ERROR;
+	}
 
 	if (s)
 		DEBUG(transaction->pakfire, "%s", s);