From: Stefano Lattarini <stefano.lattarini@gmail.com>
Date: Wed, 1 Jun 2011 14:45:19 +0000 (+0200)
Subject: tests: prefer `skip_' over `echo ...; Exit 77'
X-Git-Tag: ng-0.5a~89^2~213
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c6f28c7dae471c56616783952909a64e9543e34a;p=thirdparty%2Fautomake.git

tests: prefer `skip_' over `echo ...; Exit 77'

* tests/self-check-cleanup.test: When the test must be skipped,
use `skip_ REASON' instead of `echo REASON; Exit 77'.  Also,
make the skip message shorter and clearer.
---

diff --git a/ChangeLog b/ChangeLog
index 7100f28cd..cc9dd2ebe 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2011-06-01  Stefano Lattarini  <stefano.lattarini@gmail.com>
+
+	tests: prefer `skip_' over `echo ...; Exit 77'
+	* tests/self-check-cleanup.test: When the test must be skipped,
+	use `skip_ REASON' instead of `echo REASON; Exit 77'.  Also,
+	make the skip message shorter and clearer.
+
 2011-06-01  Stefano Lattarini  <stefano.lattarini@gmail.com>
 
 	tests: fix spurious failures in self tests
diff --git a/tests/self-check-cleanup.test b/tests/self-check-cleanup.test
index f9a865895..766031690 100755
--- a/tests/self-check-cleanup.test
+++ b/tests/self-check-cleanup.test
@@ -20,8 +20,7 @@
 . ./defs || Exit 1
 
 if test x"$sh_errexit_works" != x"yes"; then
-  echo "$me: the shell can't have a working exit trap with 'set -e'" >&2
-  Exit 77
+  skip_ "$me: no working exit trap with 'set -e'"
 fi
 
 # We still need a little hack to make ./defs work outside automake's