From: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Date: Thu, 29 Sep 2022 10:20:27 +0000 (+0530)
Subject: tools/cgcreate: use exit code 129 on invalid usage
X-Git-Tag: v3.1.0~297
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c6f59dce4f5ef39a70e7775ab8a6ea89dc5ce469;p=thirdparty%2Flibcgroup.git

tools/cgcreate: use exit code 129 on invalid usage

The exit code 1 refers to general error and using -1 wraps to
255, both codes do not signify bad arguments. Let's use exit code 129
(EXIT_BADARGS) for hinting to the users about invalid usage.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
---

diff --git a/src/tools/cgcreate.c b/src/tools/cgcreate.c
index 96d015a9..2ef8d997 100644
--- a/src/tools/cgcreate.c
+++ b/src/tools/cgcreate.c
@@ -80,7 +80,7 @@ int main(int argc, char *argv[])
 	/* no parametr on input */
 	if (argc < 2) {
 		usage(1, argv[0]);
-		return -1;
+		exit(EXIT_BADARGS);
 	}
 
 	cgroup_list = calloc(capacity, sizeof(struct cgroup_group_spec *));
@@ -112,7 +112,7 @@ int main(int argc, char *argv[])
 			if (ret) {
 				err("%s: cgroup controller and path parsing failed (%s)\n",
 				    argv[0], argv[optind]);
-				ret = -1;
+				ret = EXIT_BADARGS;
 				goto err;
 			}
 			break;
@@ -136,7 +136,7 @@ int main(int argc, char *argv[])
 			break;
 		default:
 			usage(1, argv[0]);
-			ret = -1;
+			ret = EXIT_BADARGS;
 			goto err;
 		}
 	}
@@ -144,7 +144,7 @@ int main(int argc, char *argv[])
 	/* no cgroup name */
 	if (argv[optind]) {
 		err("%s: wrong arguments (%s)\n", argv[0], argv[optind]);
-		ret = -1;
+		ret = EXIT_BADARGS;
 		goto err;
 	}