From: Jouni Malinen <j@w1.fi>
Date: Sat, 18 Jul 2015 15:09:57 +0000 (+0300)
Subject: FST: Remove unreachable code in fst_session_handle_tear_down()
X-Git-Tag: hostap_2_5~353
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c715d5c36cace1c86ef5077e970119fe2980760a;p=thirdparty%2Fhostap.git

FST: Remove unreachable code in fst_session_handle_tear_down()

fst_session_is_in_progress() is already checked as part of
fst_find_session_in_progress() before calling
fst_session_handle_action(). This is the only call path that can reach
fst_session_handle_tear_down() and as such, fst_session_is_in_progress()
cannot return 0 here.

Signed-off-by: Jouni Malinen <j@w1.fi>
---

diff --git a/src/fst/fst_session.c b/src/fst/fst_session.c
index 10fb247ea..2f42b12d6 100644
--- a/src/fst/fst_session.c
+++ b/src/fst/fst_session.c
@@ -615,11 +615,6 @@ static void fst_session_handle_tear_down(struct fst_session *s,
 		},
 	};
 
-	if (!fst_session_is_in_progress(s)) {
-		fst_printf_session(s, MSG_WARNING, "no FST Setup to tear down");
-		return;
-	}
-
 	if (plen < sizeof(*td)) {
 		fst_printf_session(s, MSG_WARNING,
 				   "Too short FST Tear Down dropped");