From: Ramiro Morales <ramiro@rmorales.net>
Date: Sun, 5 Apr 2015 22:14:54 +0000 (-0300)
Subject: - pymssql has PEP249 Binary contructor since 2.1.1
X-Git-Tag: rel_1_0_0~11^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c75c6732b115c136043eb5c74d4388abe865d2a3;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

- pymssql has PEP249 Binary contructor since 2.1.1

See https://github.com/pymssql/pymssql/commit/e7fb15dd29090e1f1bb570842b53aea1ec32d8f0
---

diff --git a/lib/sqlalchemy/dialects/mssql/pymssql.py b/lib/sqlalchemy/dialects/mssql/pymssql.py
index 2214d18d14..324b3770c2 100644
--- a/lib/sqlalchemy/dialects/mssql/pymssql.py
+++ b/lib/sqlalchemy/dialects/mssql/pymssql.py
@@ -46,11 +46,12 @@ class MSDialect_pymssql(MSDialect):
     @classmethod
     def dbapi(cls):
         module = __import__('pymssql')
-        # pymmsql doesn't have a Binary method.  we use string
-        # TODO: monkeypatching here is less than ideal
-        module.Binary = lambda x: x if hasattr(x, 'decode') else str(x)
-
+        # pymmsql < 2.1.1 doesn't have a Binary method.  we use string
         client_ver = tuple(int(x) for x in module.__version__.split("."))
+        if client_ver < (2, 1, 1):
+            # TODO: monkeypatching here is less than ideal
+            module.Binary = lambda x: x if hasattr(x, 'decode') else str(x)
+
         if client_ver < (1, ):
             util.warn("The pymssql dialect expects at least "
                       "the 1.0 series of the pymssql DBAPI.")