From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Tue, 16 Jun 2015 03:01:59 +0000 (-0400)
Subject: Fix for same memory leak in cos_socket_recv
X-Git-Tag: release_3_0_9~150
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c7677cbd04fc954d49b5649ab6217397386854de;p=thirdparty%2Ffreeradius-server.git

Fix for same memory leak in cos_socket_recv
---

diff --git a/src/main/listen.c b/src/main/listen.c
index f739cd47773..512285463e6 100644
--- a/src/main/listen.c
+++ b/src/main/listen.c
@@ -1567,9 +1567,9 @@ static int auth_socket_recv(rad_listen_t *listener)
 	 */
 	packet = rad_recv(ctx, listener->fd, client->message_authenticator);
 	if (!packet) {
-		talloc_free(ctx);
 		FR_STATS_INC(auth, total_malformed_requests);
 		if (DEBUG_ENABLED) ERROR("Receive - %s", fr_strerror());
+		talloc_free(ctx);
 		return 0;
 	}
 
@@ -1955,12 +1955,14 @@ static int coa_socket_recv(rad_listen_t *listener)
 	if (!packet) {
 		FR_STATS_INC(coa, total_malformed_requests);
 		ERROR("Receive - %s", fr_strerror());
+		talloc_free(ctx);
 		return 0;
 	}
 
 	if (!request_receive(ctx, listener, packet, client, fun)) {
 		FR_STATS_INC(coa, total_packets_dropped);
 		rad_free(&packet);
+		talloc_free(ctx);
 		return 0;
 	}