From: Daniel P. Berrangé <berrange@redhat.com>
Date: Mon, 30 Sep 2019 15:56:33 +0000 (+0100)
Subject: admin: fix memory leak of typed parameters getting client info
X-Git-Tag: v5.8.0-rc1~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c76dc0ea39b4cbddaf9be22d50d13c4f529d6e2e;p=thirdparty%2Flibvirt.git

admin: fix memory leak of typed parameters getting client info

In the error code path, the temporary parameters are not freed.

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/src/admin/admin_server.c b/src/admin/admin_server.c
index 248df3f795..0d6091937d 100644
--- a/src/admin/admin_server.c
+++ b/src/admin/admin_server.c
@@ -310,6 +310,8 @@ adminClientGetInfo(virNetServerClientPtr client,
     ret = 0;
 
  cleanup:
+    if (tmpparams)
+        virTypedParamsFree(tmpparams, *nparams);
     virObjectUnref(identity);
     VIR_FREE(sock_addr);
     return ret;