From: Max Kanat-Alexander <mkanat@bugzilla.org>
Date: Sun, 1 Aug 2010 22:50:26 +0000 (-0700)
Subject: Bug 581327: The patch to allow commas in Product (etc.) names broke the
X-Git-Tag: bugzilla-3.7.3~21
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c7c29e92562a61e16d03739d18fc03c2bdb51716;p=thirdparty%2Fbugzilla.git

Bug 581327: The patch to allow commas in Product (etc.) names broke the
entering of comma-separated values in other search fields, like bug_id.
So now we split on commas in text fields, but not for <select> fields.
r=LpSolit, a=LpSolit
---

diff --git a/Bugzilla/Search.pm b/Bugzilla/Search.pm
index c99fcde282..f93743e2a2 100644
--- a/Bugzilla/Search.pm
+++ b/Bugzilla/Search.pm
@@ -564,7 +564,8 @@ sub init {
     }
 
     foreach my $field ($params->param()) {
-        if (grep { $_->name eq $field } @legal_fields) {
+        my ($field_obj) = grep { $_->name eq $field } @legal_fields;
+        if ($field_obj) {
             my $type = $params->param("${field}_type");
             my @values = $params->param($field);
             if (!$type) {
@@ -577,7 +578,10 @@ sub init {
             }
             $type = 'matches' if $field eq 'content';
             my $send_value = join(',', @values);
-            if ($type eq 'anyexact') {
+            if ( $type eq 'anyexact'
+                 and ($field_obj->is_select or $field eq 'version'
+                      or $field eq 'target_milestone') )
+            {
                 $send_value = \@values;
             }
             push(@specialchart, [$field, $type, $send_value]);