From: Petr Špaček <pspacek@isc.org>
Date: Thu, 7 Mar 2024 15:58:29 +0000 (+0100)
Subject: Warn about release notes without CHANGES entry
X-Git-Tag: v9.18.26~3^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c7cc09185c810f955bf4678ab416a4e86e03e067;p=thirdparty%2Fbind9.git

Warn about release notes without CHANGES entry

(cherry picked from commit 0ba29730f7b9857aa5a11d755dcc728416c763ee)
---

diff --git a/dangerfile.py b/dangerfile.py
index c91ebd70252..3adb813c684 100644
--- a/dangerfile.py
+++ b/dangerfile.py
@@ -342,6 +342,11 @@ if changes_added_lines:
 #       RR types are a user-visible change (and so is removing support for
 #       existing ones).
 #
+#     * "Release notes" and "No CHANGES" labels are both set at the same time.
+#       (If something is worth a release note, it should surely show up in
+#       CHANGES.) MRs with certain labels set ("Documentation", "Release") are
+#       exempt because these are typically used during release process.
+#
 # - WARN if any of the following is true:
 #
 #     * This merge request does not update release notes and has the "Customer"
@@ -381,6 +386,15 @@ if release_notes_changed and not release_notes_label_set:
         "This merge request modifies release notes. "
         "Revert release note modifications or set the *Release Notes* label."
     )
+if (
+    release_notes_label_set
+    and no_changes_label_set
+    and not ("Documentation" in mr_labels or "Release" in mr_labels)
+):
+    fail(
+        "This merge request is labeled with both *Release notes* and *No CHANGES*. "
+        "A user-visible change should also be mentioned in the `CHANGES` file."
+    )
 
 if release_notes_changed:
     modified_or_new_files = danger.git.modified_files + danger.git.created_files