From: Bruno Haible <bruno@clisp.org>
Date: Fri, 12 Dec 2025 10:28:00 +0000 (+0100)
Subject: Modernize coding style: Avoid 'goto' statements where possible.
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c7ce599588e5faea6e95891bcdba69cbaecb3708;p=thirdparty%2Fgettext.git

Modernize coding style: Avoid 'goto' statements where possible.

* gettext-tools/src/msgfmt.c (get_languages): Use if/else instead of 'goto'.
---

diff --git a/gettext-tools/src/msgfmt.c b/gettext-tools/src/msgfmt.c
index 42a710a3c..ea23dd700 100644
--- a/gettext-tools/src/msgfmt.c
+++ b/gettext-tools/src/msgfmt.c
@@ -1488,47 +1488,44 @@ get_languages (string_list_ty *languages, const char *directory)
 
   linguas_file_name = xconcatenated_filename (directory, "LINGUAS", NULL);
   if (stat (linguas_file_name, &statbuf) < 0)
+    error (EXIT_SUCCESS, 0, _("%s does not exist"), linguas_file_name);
+  else
     {
-      error (EXIT_SUCCESS, 0, _("%s does not exist"), linguas_file_name);
-      goto out;
-    }
-
-  fp = fopen (linguas_file_name, "r");
-  if (fp == NULL)
-    {
-      error (EXIT_SUCCESS, 0, _("%s exists but cannot read"),
-             linguas_file_name);
-      goto out;
-    }
+      fp = fopen (linguas_file_name, "r");
+      if (fp == NULL)
+        error (EXIT_SUCCESS, 0, _("%s exists but cannot read"),
+               linguas_file_name);
+      else
+        {
+          while (!feof (fp))
+            {
+              /* Read next line from file.  */
+              int len = getline (&line_buf, &line_len, fp);
 
-  while (!feof (fp))
-    {
-      /* Read next line from file.  */
-      int len = getline (&line_buf, &line_len, fp);
+              /* In case of an error leave loop.  */
+              if (len < 0)
+                break;
 
-      /* In case of an error leave loop.  */
-      if (len < 0)
-        break;
+              /* Remove trailing '\n' and trailing whitespace.  */
+              if (len > 0 && line_buf[len - 1] == '\n')
+                line_buf[--len] = '\0';
+              while (len > 0
+                     && (line_buf[len - 1] == ' '
+                         || line_buf[len - 1] == '\t'
+                         || line_buf[len - 1] == '\r'))
+                line_buf[--len] = '\0';
+
+              /* Test if we have to ignore the line.  */
+              if (!(*line_buf == '\0' || *line_buf == '#'))
+                /* Include the line among the languages.  */
+                add_languages (languages, desired_languages, line_buf, len);
+            }
 
-      /* Remove trailing '\n' and trailing whitespace.  */
-      if (len > 0 && line_buf[len - 1] == '\n')
-        line_buf[--len] = '\0';
-      while (len > 0
-             && (line_buf[len - 1] == ' '
-                 || line_buf[len - 1] == '\t'
-                 || line_buf[len - 1] == '\r'))
-        line_buf[--len] = '\0';
-
-      /* Test if we have to ignore the line.  */
-      if (!(*line_buf == '\0' || *line_buf == '#'))
-        /* Include the line among the languages.  */
-        add_languages (languages, desired_languages, line_buf, len);
+          free (line_buf);
+          fclose (fp);
+        }
     }
 
-  free (line_buf);
-  fclose (fp);
-
- out:
   if (desired_languages != NULL)
     string_list_destroy (desired_languages);
   free (linguas_file_name);