From: Tim Duesterhus <tim@bastelstu.be>
Date: Tue, 26 Feb 2019 16:09:50 +0000 (+0100)
Subject: CLEANUP: http: Remove unreachable code in parse_http_req_capture
X-Git-Tag: v2.0-dev2~176
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c7f880ee3bcc89e304d16849124c4806bf82d8cc;p=thirdparty%2Fhaproxy.git

CLEANUP: http: Remove unreachable code in parse_http_req_capture

`len` has already been checked to be strictly positive a few lines above.

This unreachable code was introduced in 82bf70dff4eff42397fecfcb9e97a0a7ce721c49.
---

diff --git a/src/http_act.c b/src/http_act.c
index 4f51d4a2ed..0346be0cb6 100644
--- a/src/http_act.c
+++ b/src/http_act.c
@@ -375,12 +375,6 @@ static enum act_parse_ret parse_http_req_capture(const char **args, int *orig_ar
 		}
 		cur_arg++;
 
-		if (!len) {
-			memprintf(err, "a positive 'len' argument is mandatory");
-			free(expr);
-			return ACT_RET_PRS_ERR;
-		}
-
 		hdr = calloc(1, sizeof(*hdr));
 		hdr->next = px->req_cap;
 		hdr->name = NULL; /* not a header capture */