From: James Jones <jejones3141@gmail.com>
Date: Sat, 9 Jul 2022 00:31:06 +0000 (-0500)
Subject: Accomodate coverity in tls_cache_session_ticket_app_data_get() (CID #1503904) (#4604)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c7fe2ed01d00841c50c6e4cc856f2633cf656ef8;p=thirdparty%2Ffreeradius-server.git

Accomodate coverity in tls_cache_session_ticket_app_data_get() (CID #1503904) (#4604)

Make the default appear for coverity as well as for clang static
analysis, for the same reason: otherwise, an unexpected status
could pass a NULL request to tls_cache_app_data_get().
---

diff --git a/src/lib/tls/cache.c b/src/lib/tls/cache.c
index 20f87c7177c..5e17dd92d1a 100644
--- a/src/lib/tls/cache.c
+++ b/src/lib/tls/cache.c
@@ -1268,7 +1268,7 @@ static SSL_TICKET_RETURN tls_cache_session_ticket_app_data_get(SSL *ssl, SSL_SES
 	case SSL_TICKET_FATAL_ERR_MALLOC:
 	case SSL_TICKET_FATAL_ERR_OTHER:
 	case SSL_TICKET_NONE:
-#ifdef __clang_analyzer__
+#if defined(__clang_analyzer__) || defined(__COVERITY__)
 	default:
 #endif
 		return SSL_TICKET_RETURN_IGNORE_RENEW;	/* Send a new ticket */