From: Alan T. DeKok <aland@freeradius.org>
Date: Wed, 13 Apr 2022 14:58:20 +0000 (-0400)
Subject: sign / unsign issues
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c8045b6795c62ae6899d5a9ace9710a89cdc8b9f;p=thirdparty%2Ffreeradius-server.git

sign / unsign issues

because the compiler is too stupid to notice that we check for
(ssize_t) foo < 0, and disallow it.
---

diff --git a/src/listen/tacacs/proto_tacacs_tcp.c b/src/listen/tacacs/proto_tacacs_tcp.c
index 85d7dd2f68b..e08dac1913f 100644
--- a/src/listen/tacacs/proto_tacacs_tcp.c
+++ b/src/listen/tacacs/proto_tacacs_tcp.c
@@ -143,7 +143,7 @@ static ssize_t mod_read(fr_listen_t *li, UNUSED void **packet_ctx, fr_time_t *re
 	packet_len = fr_tacacs_length(buffer, in_buffer);
 	if (packet_len < 0) return -1;
 
-	if (in_buffer < packet_len) {
+	if (in_buffer < (size_t) packet_len) {
 		*leftover = in_buffer;
 		return 0;
 	}
@@ -152,7 +152,7 @@ static ssize_t mod_read(fr_listen_t *li, UNUSED void **packet_ctx, fr_time_t *re
 	 *	We've read more than one packet.  Tell the caller that
 	 *	there's more data available, and return only one packet.
 	 */
-	if (in_buffer > packet_len) {
+	if (in_buffer > (size_t) packet_len) {
 		*leftover = in_buffer - packet_len;
 	}