From: Volker Lendecke <vl@samba.org>
Date: Tue, 15 May 2018 11:28:19 +0000 (+0200)
Subject: ctdb-common: Fix CID 1435600
X-Git-Tag: ldb-1.4.0~206
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c853a8071a6efafe92e7df608ec636f43aa9d371;p=thirdparty%2Fsamba.git

ctdb-common: Fix CID 1435600

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Wed May 16 09:51:07 CEST 2018 on sn-devel-144
---

diff --git a/ctdb/common/logging.c b/ctdb/common/logging.c
index 3cc19331bab..dc8c4f75058 100644
--- a/ctdb/common/logging.c
+++ b/ctdb/common/logging.c
@@ -173,13 +173,12 @@ static bool file_log_validate(const char *option)
 	dir = dirname(t);
 
 	ret = stat(dir, &st);
+	free(t);
 	if (ret != 0) {
-		free(t);
 		return false;
 	}
 
 	if (! S_ISDIR(st.st_mode)) {
-		free(t);
 		return false;
 	}