From: Roi Dayan Date: Thu, 19 Jan 2017 12:31:19 +0000 (+0200) Subject: tc: flower: Add missing err check when parsing flower options X-Git-Tag: v4.10.0~22 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c85609b25faff034d450b0106fac7932d6acf124;p=thirdparty%2Fiproute2.git tc: flower: Add missing err check when parsing flower options addattr32 may return an error. Fixes: cfcabf18d84a ("tc: flower: Add skip_{hw|sw} support") Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- diff --git a/tc/f_flower.c b/tc/f_flower.c index 1dbc5320f..1272a471a 100644 --- a/tc/f_flower.c +++ b/tc/f_flower.c @@ -525,7 +525,9 @@ static int flower_parse_opt(struct filter_util *qu, char *handle, } parse_done: - addattr32(n, MAX_MSG, TCA_FLOWER_FLAGS, flags); + ret = addattr32(n, MAX_MSG, TCA_FLOWER_FLAGS, flags); + if (ret) + return ret; ret = addattr16(n, MAX_MSG, TCA_FLOWER_KEY_ETH_TYPE, eth_type); if (ret) {