From: Stefan Metzmacher <metze@samba.org>
Date: Tue, 11 Mar 2025 10:44:25 +0000 (+0100)
Subject: s4:kdc: let samba_kdc_entry_pac[_from_trusted]() assert krbtgt is valid if pac is... 
X-Git-Tag: tevent-0.17.0~390
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c87f66ebac37d4bab7c34f95ec0f3c347360e894;p=thirdparty%2Fsamba.git

s4:kdc: let samba_kdc_entry_pac[_from_trusted]() assert krbtgt is valid if pac is valid

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source4/kdc/pac-glue.c b/source4/kdc/pac-glue.c
index 7e680a42592..6eec1fc86d1 100644
--- a/source4/kdc/pac-glue.c
+++ b/source4/kdc/pac-glue.c
@@ -879,6 +879,10 @@ struct samba_kdc_entry_pac samba_kdc_entry_pac(krb5_const_pac pac,
 					       struct samba_kdc_entry *entry,
 					       const struct samba_kdc_entry *krbtgt)
 {
+	if (pac != NULL) {
+		SMB_ASSERT(krbtgt != NULL);
+	}
+
 	return (struct samba_kdc_entry_pac) {
 		.entry = entry,
 		.krbtgt = krbtgt,
@@ -891,6 +895,10 @@ struct samba_kdc_entry_pac samba_kdc_entry_pac_from_trusted(krb5_const_pac pac,
 							    const struct samba_kdc_entry *krbtgt,
 							    bool is_trusted)
 {
+	if (pac != NULL) {
+		SMB_ASSERT(krbtgt != NULL);
+	}
+
 	return (struct samba_kdc_entry_pac) {
 		.entry = entry,
 		.krbtgt = krbtgt,